Fix/issue 632 dashboard form a11y - #992
Open
Benedict315 wants to merge 3 commits into
Open
Conversation
Benedict315
force-pushed
the
fix/issue-632-dashboard-form-a11y
branch
from
July 11, 2026 17:10
1971738 to
826162d
Compare
ogazboiz
requested changes
Aug 3, 2026
ogazboiz
left a comment
ogazboiz
left a comment
Contributor
There was a problem hiding this comment.
the a11y hunk itself is fine, but note main's labels already wrap their inputs (valid implicit association), so please confirm which control was actually failing the #632 audit. blockers:
- remove the Cargo.toml [patch.crates-io] ethnum entry, it points at the same source and breaks every rust CI job ("patches must point to different sources").
- remove the soroban-sdk bump and the backend/frontend vitest bumps, dependency updates are dependabot's job.
- keep only the dashboard-view.tsx hunk.
if you want to keep contributing, join us on Telegram: https://t.me/+DOylgFv1jyJlNzM0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Related Issues
Closes #632
Changes Made
Testing
Test Coverage
Test Steps
Breaking Changes
Breaking Changes:
Migration Guide:
Screenshots/Demo
Checklist
Additional Notes